Remove registry overrides when building app kwargs #1072
Merged
+13
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were (per the comments) intended to be used for testing but do not appear to be used anywhere.
tpoliaw
force-pushed
the
deconstruct_kwargs
branch
from
8508c32 to
2dd6a0c
Compare
Member
|
I'll need to take a close look at this to recall what the intent what here. Will try to get to it today or tomorrow. |
Contributor
Author
|
The registries can still be overridden in tests using the For a bit of wider context, I'm hoping to incrementally get to the same state that #928 aimed for without being in one 1k line PR. |
danielballan
approved these changes
Aug 8, 2025
Member
|
OK, agreed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were (per the comments) intended to be used for testing but do not
appear to be used anywhere.